Policy: Content Caching disable totally #1278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidor
reviewed
Jun 7, 2021
|
|
||
|
|
||
|
|
||
| === TEST 8: HEAD request is enabled if no content-caching |
There was a problem hiding this comment.
Would be good to add a brief explanation here or in TEST 9 that clarifies that this is tested because of https://nginx.org/en/docs/http/ngx_http_proxy_module.html#proxy_cache_convert_head
When using content_cache and proxy_no_cache, some directives are still in place, and was causing issues to a few users regarding HEAD request, etc.. This commit disabled the proxy_cache globally based on cache_zone variable. FIX THREESCALE-7016 Signed-off-by: Eloy Coto <eloy.coto@acalustra.com>
davidor
approved these changes
Jun 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using content_cache and proxy_no_cache, some directives are still
in place, and was causing issues to a few users regarding HEAD request,
etc..
This commit disabled the proxy_cache globally based on cache_zone
variable.
FIX THREESCALE-7016
Signed-off-by: Eloy Coto eloy.coto@acalustra.com