Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIRCLECI: push containers with latest tag when build master git branch #1289

Merged
merged 1 commit into from
Jul 21, 2021

Conversation

eloycoto
Copy link
Contributor

When using master branch, the quay.io images are reference as master.
The operator team wants to have the name as latest, so all components
can have the same naming.

FIX https://issues.redhat.com/browse/THREESCALE-7251

Signed-off-by: Eloy Coto eloy.coto@acalustra.com

@eloycoto eloycoto requested a review from a team as a code owner July 19, 2021 10:55
When using master branch, the quay.io images are reference as master.
The operator team wants to have the name as latest, so all components
can have the same naming.

FIX https://issues.redhat.com/browse/THREESCALE-7251

Signed-off-by: Eloy Coto <eloy.coto@acalustra.com>
Copy link
Contributor

@unleashed unleashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good, but it is replacing the master tag with latest, so there will no longer be a master tag. Is that what we want? We could still create both tags and push them at once.

@eloycoto
Copy link
Contributor Author

Yep, latest is the preferred option now :-)

@eloycoto eloycoto merged commit 78538b4 into 3scale:master Jul 21, 2021
@unleashed
Copy link
Contributor

Well, I was asking because IIUIC now we'll lack a master tag, so if anyone was following those they'll be stuck.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants