FIX: routing policy catch-all condition #1296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eloycoto
force-pushed
the
THREESCALE-6415
branch
from
15a17e0
to
7faaf0d
Compare
unleashed
reviewed
Aug 12, 2021
Comment on lines
+2326
to
+2332
| { | ||
| "match": "path", | ||
| "op": "==", | ||
| "value": "/a_path" | ||
| } | ||
| ] |
There was a problem hiding this comment.
shouldn't we add a test with conditions.operations equal to nil?
Edit: that would be accomplished by leaving it empty here as reported in the ticket []?
eloycoto
force-pushed
the
THREESCALE-6415
branch
from
7faaf0d
to
d99b598
Compare
unleashed
approved these changes
Aug 12, 2021
When operations is empty was working as expected, but when it was nil, raises an excpetion and routing policy was not working as expected. FIX https://issues.redhat.com/browse/THREESCALE-6415 Signed-off-by: Eloy Coto <eloy.coto@acalustra.com>
eloycoto
force-pushed
the
THREESCALE-6415
branch
from
d99b598
to
58f9f73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When operations is empty was working as expected, but when it was nil,
raises an excpetion and routing policy was not working as expected.
FIX https://issues.redhat.com/browse/THREESCALE-6415
Signed-off-by: Eloy Coto eloy.coto@acalustra.com