Upstream: Do not append a trailing / on the end. #1298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eloycoto
force-pushed
the
THREESCALE-7146
branch
2 times, most recently
from
f9e4340
to
f489bb9
Compare
unleashed
approved these changes
Aug 16, 2021
eloycoto
force-pushed
the
THREESCALE-7146
branch
from
f489bb9
to
438f4d0
Compare
guicassolato
approved these changes
Aug 16, 2021
eloycoto
force-pushed
the
THREESCALE-7146
branch
from
065f970
to
438f4d0
Compare
If the tmp_path is empty on upstream:append_path, we should add the trailing slash, as resty_url:join is doing. Fix https://issues.redhat.com/browse/THREESCALE-7146 Reported-by: sillumin@redhat.com Signed-off-by: Eloy Coto <eloy.coto@acalustra.com>
eloycoto
force-pushed
the
THREESCALE-7146
branch
from
438f4d0
to
2273886
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the tmp_path is empty on upstream:append_path, we should add the
trailing slash, as resty_url:join is doing.
Fix https://issues.redhat.com/browse/THREESCALE-7146
Reported-by: sillumin@redhat.com
Signed-off-by: Eloy Coto eloy.coto@acalustra.com