Policy: upstream MTLS fix on verify. #1307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unleashed
approved these changes
Sep 1, 2021
eloycoto
force-pushed
the
MTLSCACERTIssue
branch
from
188e3d7
to
cc155f4
Compare
Before, if not CA cert was set, we don't set the verify at all, but this is a bad behaviour because: - CA certs can be the global ones. - Verify is true, so should fail. Now, if not CA proxy will return a 502 back to the user. Fix THREESCALE-7508 Signed-off-by: Eloy Coto <eloy.coto@acalustra.com>
eloycoto
force-pushed
the
MTLSCACERTIssue
branch
from
cc155f4
to
032f9df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, if not CA cert was set, we don't set the verify at all, but this
is a bad behaviour because:
Now, if not CA proxy will return a 502 back to the user.
Fix THREESCALE-7508
Signed-off-by: Eloy Coto eloy.coto@acalustra.com