THREESCALE-7906 #1318
Closed
THREESCALE-7906 #1318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under some error circumstances (like 414 Request-URI Too Large) the access log were generated in a phase previous to having defined the access_log_enabled and the extended_access_logs_enabled. This causes a warning to arise, but most importanty, prevented that acces to be logged. We use the workarround of declaring the variables as a map with a default value because maps can be used in the http context and therefore will be available and initialized even on the given error case.
Allow CAPITAL letters on branches for the docker scripts of CircleCI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under some error circumstances (like 414 Request-URI Too Large) the access log were generated in a phase previous to having defined the access_log_enabled and the extended_access_logs_enabled.
This causes a warning to arise, but most important, prevented that access to be logged.
We use the workaround of declaring the variables as a map with a default value, because maps can be used in the NGINX http context and therefore will be available and initialized even on the given error case.