-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
THREESCALE-7735 THREESCALE-8865 opentelemetry instrumentation #1379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
d0c04fe
to
50d21e8
Compare
59a3814
to
13d4a9e
Compare
ready for review @3scale/apicast-core |
lcavalle
requested changes
Feb 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Text proofreading
1f230df
to
8af8b1c
Compare
8af8b1c
to
189c6bd
Compare
lcavalle
approved these changes
Feb 23, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
implements THREESCALE-7735
Specifically the subtask THREESCALE-8865
Adds OpenTelemetry distributed tracing support to Apicast.
Supported propagation types: W3C
Jaeger has deprecated the jaeger native clients. From Jaeger doc
Jaeger client (based on opentracing) support is still in place, but gets deprecated in favor of the Opentelemetry use. When opentracing is enabled, APIcast will log warning:
Add local dev environment with docker compose
make opentelemetry-gateway IMAGE_NAME=my-local-image
Tasks
Verification steps
Build runtime image
Run test env with APIcast enabled with Opentelemetry and with jeager instance up and running
Get the IP of APIcast
Send request to APIcast
Note that upstream echo'ed request headers show
Traceparent
W3C standard tracing headerOpen in local browser jaeger dashboard
Hit "Find Traces" with Services set to
apicast
. There should be at lease one traceAnd opening the, the "process" should show attribute
telemetry.sdk.name = opentelemetry