Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apicast-mapping-rules.t conversion to APIcast::Blackbox #1430

Merged
merged 1 commit into from
Nov 24, 2023
Merged

apicast-mapping-rules.t conversion to APIcast::Blackbox #1430

merged 1 commit into from
Nov 24, 2023

Conversation

tkan145
Copy link
Contributor

@tkan145 tkan145 commented Nov 23, 2023

Fixes #1365

@tkan145 tkan145 requested a review from a team as a code owner November 23, 2023 05:15
@tkan145 tkan145 requested a review from eguzki November 23, 2023 05:34
@tkan145 tkan145 mentioned this pull request Nov 24, 2023
Merged
eguzki
eguzki requested changes Nov 24, 2023
View reviewed changes
Copy link
Member

@eguzki eguzki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looking good.

minor issues

t/apicast-mapping-rules.t Outdated Show resolved Hide resolved
t/apicast-mapping-rules.t Show resolved Hide resolved
@tkan145 tkan145 force-pushed the apicast-mapping-rules.t-conversion_to_blackbox branch from 7ce5297 to b7ea7a8 Compare November 24, 2023 12:36
@tkan145 tkan145 requested a review from eguzki November 24, 2023 12:49
@tkan145 tkan145 merged commit ac68219 into 3scale:master Nov 24, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eguzki eguzki eguzki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

apicast-mapping-rules.t
2 participants
@tkan145 @eguzki