Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create k8s Ingress objects [THREESCALE-2686] #199

Merged
merged 3 commits into from
Jun 14, 2019
Merged

Create k8s Ingress objects [THREESCALE-2686] #199

merged 3 commits into from
Jun 14, 2019

Conversation

mikz
Copy link
Contributor

@mikz mikz commented Jun 4, 2019

TODO

  • configuration file to enable/disable k8s integration
  • create ingress for admin and dev portal
  • create ingress for production and staging apicast

Depends on 3scale/porta#844
Depends on 3scale/3scale-operator#145

Gemfile Outdated
@@ -42,6 +42,7 @@ gem 'bugsnag-capistrano', '< 2', require: false
# https://github.com/nahi/httpclient/issues/369
gem 'httpclient', github: 'mikz/httpclient', branch: 'ssl-env-cert'
gem 'oauth2'
gem 'k8s-client'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason you preferred not to use https://github.com/abonas/kubeclient?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @unleashed suggested using this one. I don't really have a preference.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you wish. https://github.com/3scale/porta is using https://github.com/abonas/kubeclient. @abonas is Alissa Bonas, Red Hatter, BTW.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm. Looks I got it confused and picked a wrong one :)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guicassolato yes I am :)
The library is currently fantastically maintained by @cben , also a Red Hatter

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh, a 3rd client 🎉, I wasn't aware of this one.
(the other one I knew is https://github.com/kubernetes-client/ruby, documented "WIP" though picking up development recently)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @abonas and @cben. We've been successfully using the gem in 3scale for OpenShift to discover manageable services deployed onto the same cluster.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to stick with k8s-client for now. We are on a pretty tight schedule. It's K8s::Client.autoconfig is a very easy way for us to get a working client. I tried to do the same with kubeclient, but Config & Context do not expose namespace. I don't really have the time now to contribute, but will revisit it in the future.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The one I suggested is k8s-client, yes, after attending their talk @ KubeCon EU 2019, which I recommend anyone interested (both users & maintainers) to watch. I remembered there was another one by a redhatter (now I see it's @abonas' & @cben's one) but got the impression it was not actively maintained, which it would seem is not quite true. :)

@mikz mikz changed the title Create k8s Ingress objects Create k8s Ingress objects [THREESCALE-2686] Jun 6, 2019
@mikz mikz force-pushed the k8s-routes branch 7 times, most recently from 09c5a54 to 8aaf7ce Compare June 14, 2019 09:39
@mikz mikz marked this pull request as ready for review June 14, 2019 09:42
mikz added 2 commits June 14, 2019 11:53
Create OpenShift Route objects when Provider/Proxy are
created/updated/deleted.
it tries to mutate frozen strings
@mikz mikz merged commit aaf2258 into master Jun 14, 2019
@mikz mikz deleted the k8s-routes branch June 14, 2019 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants