Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves image loading callback customisation #60

Merged
merged 2 commits into from
Apr 4, 2020

Conversation

simonmitchell
Copy link
Contributor

Description

Adds option to setImageURLs to force the completion block to be called on each image load rather than just the first!

Motivation and Context

Solves issue when you may want to show progressively large images as a loading mechanism

How Has This Been Tested?

Tested in my personal app when loading image previews (Camrote)... In production!

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

…d on

each image load rather than just the first!
@simonmitchell simonmitchell merged commit 1ae91ba into develop Apr 4, 2020
@simonmitchell simonmitchell deleted the feature/image_loading_improvements branch April 4, 2020 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants