Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request recharge time is too long #250

Closed
pushkinb opened this issue Jun 14, 2024 · 6 comments
Closed

request recharge time is too long #250

pushkinb opened this issue Jun 14, 2024 · 6 comments
Labels
Bug Something isn't working and the problem is in the code Fixed The issue is now fixed

Comments

@pushkinb
Copy link

Question or issue you are experiencing
Please explain your question here. If you've got an error or something else related, then please include it here as well.

hi, when I use a command, sometimes I encounter failed, and when I need an even amount I want to reuse it, but I don't understand why the program asks to wait such a long time

image

my config:
image

Additional information
Please add any other information here, if you have some.

@pushkinb pushkinb added the Question Further information is requested label Jun 14, 2024
@pushkinb
Copy link
Author

I want to reduce this delay but I can't find such a setting.

@3urobeat
Copy link
Owner

Hey, thanks for opening an issue.

When encountering "HTTP Error 429" or "you've been posting too frequently, and can't make another post right now" the bot adds 5 minutes to the length of the request (basically preventing the accounts from being used for another 5 minutes).
This seems to be hardcoded.

I'm not exactly sure why you are getting a 40 minute cooldown when you have both cooldowns disabled in the config.
Just from a quick glance at the code, it could be that the request-length-extension-thing stacks, which I don't think is intended.

How many comments failed in that request from your first screenshot? Knowing that could maybe answer that theory.

@pushkinb
Copy link
Author

Hi, I only got 10 errors at that moment.
image

@3urobeat
Copy link
Owner

Depending on which errors you encountered my theory might make sense.
I'll test this when working on the next update. The extended cooldown should not stack, that is not intended and will be fixed if it is the case.

@3urobeat 3urobeat added Bug Something isn't working and the problem is in the code and removed Question Further information is requested labels Jun 27, 2024
@3urobeat
Copy link
Owner

3urobeat commented Aug 10, 2024

This has been fixed, the 5 min IP cooldown penalty will only be applied once to a request instead of stacking incorrectly.

The fix will be included in Version 2.15.3. I'll leave this issue open until the update is out on the master branch.

Edit: I could maybe also add an advancedconfig setting to disable this penalty, although it would not make much sense as the accounts will get reused which might extend the IP cooldown further.

@3urobeat 3urobeat added the Fixed The issue is now fixed label Aug 10, 2024
@3urobeat
Copy link
Owner

Version 2.15.3 is now out which fixes the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working and the problem is in the code Fixed The issue is now fixed
Development

No branches or pull requests

2 participants