Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

launcher: Fix ambiguous token setup instructions #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kc9jud
Copy link

@kc9jud kc9jud commented Apr 28, 2024

The previous instructions suggested that the token should be part of the command line arguments, while it should actually be passed as input.

@olivercalder
Copy link

Agreed. This confused me and I had to dig around to figure out how this was supposed to work.

On first run, we see:

A default configuration file has been created at
  /home/oac/snap/matterhorn/490/.config/matterhorn/config.ini

Use with your $EDITOR to customize it

Call this command to setup an access token:
  snap run --shell matterhorn -c \
    'secret-tool store --label="$SNAP_NAME" $SNAP_NAME <token>'

Press any key to run matterhorn...

The <token> should literally be called token, and the <token> should be pasted in when asked for a password.

I would suggest the help message say something like this instead:

A default configuration file has been created at
  /home/oac/snap/matterhorn/490/.config/matterhorn/config.ini

Use with your $EDITOR to customize it.

It is recommended to set a host URL and un-comment the `tokencmd` line once you have set an access token.

Call this command to setup an access token, and when asked for a password, paste the access token:
  snap run --shell matterhorn -c \
    'secret-tool store --label="$SNAP_NAME" $SNAP_NAME token'

Press any key to run matterhorn...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants