Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option & ".norminetteignore" file to ignore files #257

Closed
wants to merge 5 commits into from
Closed

Add option & ".norminetteignore" file to ignore files #257

wants to merge 5 commits into from

Conversation

xcxlt
Copy link

@xcxlt xcxlt commented Nov 18, 2021

No description provided.

…and add support for a ".norminetteignore" file which will ignore any exact matches with the targets.
@xcxlt
Copy link
Author

xcxlt commented Nov 18, 2021

Thinking about this again, the .norminetteignore file could be abused if the reviewer fails to see the the file and does not realize some files are being ignored. I will add an option to enable the usage of the file.

@GlaceCoding
Copy link

I think you should not add the -g alias because it is not explicit. This one could be abused by some people saying -g is for global searching. 😅

@xcxlt
Copy link
Author

xcxlt commented Nov 25, 2021

You're right.

@N0ich
Copy link
Contributor

N0ich commented Mar 17, 2022

Hello and sorry, but I can't merge this as the basic usage of the norminette should not require any ignored files. Besides, it becomes easy to "hide" files during an evaluation so all in all, it's probably safer without it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants