Improve comments #455
Merged
Improve comments #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ead of only a token
…escape restrictions
…se multi-line and one-line comments to avoid duplicating or losting chars
…er 80 characteres
matthieu42Network
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #309, #439, #433.
Bugs that this PR solves
Wrong line reported when shows a
LINE_TOO_LONG, reproduceable code:Actually, norminette says the first line is over 80 chars, but it's wrong. With 2869b27 fix, now it says correctly that is the second line over 80 chars. Related to #309 and #433
When norminette parses a comment like
/*\*/it will understand it as/*\**/, note that it "duplicates" the*, in #439 the*is aNotes