[Feat] 지원서 작성 페이지 레이아웃 구성 #1251 #1258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
yoouyeon
requested review from
a team,
yoouyeon and
greatSweetMango
and removed request for
a team
yoouyeon
reviewed
Mar 6, 2024
hooks/recruit/useRecruitDetail.ts
Outdated
Comment on lines
6
to
12
| const { data, isLoading } = useQuery<IRecruitmentDetail>( | ||
| ['recruitDetail', id], | ||
| async () => { | ||
| const res = await mockInstance.get(`/recruitments/${id}`); | ||
| return res.data; | ||
| } | ||
| ); |
There was a problem hiding this comment.
지원서 데이터는 페이지 랜더링 시에 한번만 요청하면 될 것 같은데 useQuery에 따로 옵션을 주지 않으면 되게 자주 데이터를 새로 불러오게 되거든요 (저도 옵션을 설정해놨어야 했는데 지금 보니 빼먹었네요;;)
- https://growing-jiwoo.tistory.com/113#%E-%-C%--%--refetchOnMount
- https://tanstack.com/query/v4/docs/framework/react/guides/important-defaults
위 글들 읽어봤는데 refetchOnWindowFocus 옵션 정도는 false로 설정해도 되지 않을까 싶어요!
There was a problem hiding this comment.
수정했습니다. 새로운 내용 배워갑니다! 👍
| top: 0; | ||
| width: 25rem; | ||
| background-color: rgba(246, 246, 246, 0.9); | ||
| backdrop-filter: blur(5px); |
parksangmin1543
approved these changes
Mar 7, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 개요
💻 작업사항
✅ 변경로직