Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remotenickformat-zerowidth.tengo to contrib #799

Merged
merged 1 commit into from
Apr 14, 2019

Conversation

qaisjp
Copy link
Collaborator

@qaisjp qaisjp commented Apr 14, 2019

Example situation:

  • User qaisjp is on both Discord and IRC with the same username
  • Whenever @qaisjp (Discord) speaks, a message is sent to IRC like <qaisjp> message.
  • Because the IRC username is in that string qaisjp receives a notification on IRC which can be very annoying.

This pull request includes a zero-width space between the first and second character of qaisjp so that IRC clients are not nickalerted by usernames.

This is currently in use and currently works. This is also a common solution for many bridges.

@42wim
Copy link
Owner

42wim commented Apr 14, 2019

Unless i'm mistaken, that option already exists? https://github.com/42wim/matterbridge/blob/master/matterbridge.toml.sample#L150

But it's a good example of a tengo script!
Thanks!

@42wim 42wim merged commit 220485a into 42wim:master Apr 14, 2019
@qaisjp
Copy link
Collaborator Author

qaisjp commented Apr 14, 2019

#The string "{NOPINGNICK}" (case sensitive) will be replaced by the actual nick / username, but with a ZWSP inside the nick, so the irc user with the same nick won't get pinged. See #175 for more information

Whoops, I had no idea that existed! Cheers 🙂

@qaisjp
Copy link
Collaborator Author

qaisjp commented Apr 14, 2019

Not sure the script is worth being in contrib now, maybe it would be better to add this as an example in the wiki and say that you can actually use {NOPINGNICK}.

@qaisjp qaisjp deleted the feature/tengo-nick-0width branch April 14, 2019 22:56
@42wim
Copy link
Owner

42wim commented Apr 15, 2019

I disagree, it's a good example of the tengo "power" :)
I also recently updated the documentation with all the settings on the wiki:
https://github.com/42wim/matterbridge/wiki/Settings#RemoteNickFormat

Next up is refactoring the matterbridge.toml.sample :-)

@qaisjp
Copy link
Collaborator Author

qaisjp commented Apr 15, 2019

Very nice page!

zeridon pushed a commit to zeridon/matterbridge that referenced this pull request Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants