Do not split message on newlines #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hloeung any feedback, am I missing something that maybe will break? :) |
|
Might be IRC line limits. Also a large message with a mixture of text and code blocks where texts with empty lines aren't removed? Probably not a big deal though. |
|
The IRC line limits are not an issue, we're splitting the lines before sending them on IRC wrt to empty lines I think the advantages outweigh the possible disavantage of some few empty lines when mixing codeblocks with non-code blocks. It can be optimized later though, but not a showstopper for this change. |
This was referenced Oct 15, 2022
…e message (#483) * Ensure prefixcontext/suffixcontent shown for all lines in a multi-line message * Make showing context for multi-line messages configurable * Fix to handle empty lines now that we're splitting elsewhere * Restore changes to MsgSpoofUser() and Spoof() per review * Allow overriding max. line length * Fix to correctly add message thread context * Refactor and remove duplicate code per review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #480 and as a bonus also fixes #426 as this is now just 1 big message for irc