fix: WHS stabilisation #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
franky47
added a commit
that referenced
this pull request
Jan 17, 2024
* fix: WHS has been stabilised * chore: Add test suite for 14.0.3 with WHS
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
next@14.0.5-canary.54stabilised the WHS flag in PR vercel/next.js#60557This updates the e2e test suite to no longer check for it in the canaries, and removes the check in useQueryState, as useEffect-ing over a non-reactive useSearchParams before WHS is a noop anyway.
We still need the history patch to support the pages router, as useSearchParams is not reactive there (yet?).