ci: Fix compiling pyinstaller pre-deps #1075
Conversation
WalkthroughThe recent adjustment involves transitioning the GitHub Actions workflow's dependency management to rely on Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Type: Enhancement
PR Summary: This pull request updates the workflow to compile and install PyInstaller requirements using pyproject.toml instead of setup.cfg. This change aligns with modern Python packaging practices.
Decision: Comment
📝 Type: 'Enhancement' - not supported yet.
- Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
✅ Small diff: the diff is small enough to approve with confidence.
No details provided.
General suggestions:
- Ensure that all configurations and dependencies previously defined in
setup.cfgare accurately represented inpyproject.tomlto avoid any missing or misconfigured dependencies. - Verify that the
--extra pyinstalleroption works as expected withpyproject.toml, as the handling of extras might differ fromsetup.cfg. - Consider revising the PR title for clarity and to correct the typo. A suggested title could be 'Update workflow to use pyproject.toml for PyInstaller pre-deps'.
- Review the PR description for clarity and completeness. Providing more context about the motivation behind the change and its expected impact could help reviewers understand the rationale better.
Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- .github/workflows/test_prereleases.yml (1 hunks)
Additional comments: 1
.github/workflows/test_prereleases.yml (1)
- 114-114: The command
pip-compile --upgrade -o requirements.txt pyproject.toml --extra pyinstaller --precorrectly switches dependency resolution fromsetup.cfgtopyproject.toml. Ensure thatpyproject.tomlis properly configured to handle this new role, including specifying dependencies and any necessary configurations for PyInstaller.
Czaki
changed the title
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- .github/workflows/test_prereleases.yml (2 hunks)
Files skipped from review as they are similar to previous changes (1)
- .github/workflows/test_prereleases.yml
|
Czaki
changed the title
|
@coderabbitai review |
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- .github/workflows/test_prereleases.yml (3 hunks)
Files skipped from review as they are similar to previous changes (1)
- .github/workflows/test_prereleases.yml
Fix lack of workflow update in #1070
Summary by CodeRabbit
pyproject.tomlfor generating requirements.