Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Enforce napari 0.5.0 for Qt6 bindings #1161

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

Czaki
Copy link
Collaborator

@Czaki Czaki commented Jul 19, 2024

Summary by CodeRabbit

  • New Features

    • Improved version checks for dependencies to ensure compatibility with napari and pydantic.
    • Enhanced error handling for incompatible versions of critical dependencies.
  • Bug Fixes

    • Adjusted dependency specifications for napari, requiring a minimum version of 0.5.0 for better stability, for qt6 bindings
  • Chores

    • Refined import statements for better clarity and organization within the code.

@Czaki Czaki added this to the 0.15.4 milestone Jul 19, 2024
Copy link
Contributor

coderabbitai bot commented Jul 19, 2024

Walkthrough

The recent updates introduce enhanced version checks for the napari and pydantic libraries in the launcher_main.py file, ensuring compatibility and stability. Additionally, the pyproject.toml file has been modified to enforce minimum version requirements for these dependencies, promoting the use of more recent and reliable versions. These changes help prevent issues related to outdated packages and improve overall project robustness.

Changes

Files Change Summary
package/PartSeg/launcher_main.py, pyproject.toml Enhanced version checks for napari and pydantic in launcher_main.py. Updated dependency versions in pyproject.toml to require napari at least >=0.5.0 for both pyqt6 and pyside6_experimental.

Poem

In the code where rabbits play,
New checks and balances sway.
Napari hops to version bright,
Pydantic stays within the light.
Dependencies dance in harmony,
A stable world for you and me! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

sourcery-ai bot commented Jul 19, 2024

🧙 Sourcery has finished reviewing your pull request!


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

Copy link

sonarcloud bot commented Jul 19, 2024

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 46be04f and 3041bf8.

Files selected for processing (2)
  • package/PartSeg/launcher_main.py (3 hunks)
  • pyproject.toml (2 hunks)
Additional comments not posted (6)
package/PartSeg/launcher_main.py (4)

82-92: Ensure correct version checks for napari and pydantic.

The version check logic looks correct. It ensures that napari is at least version 0.4.19 and pydantic is version 2 or lower. However, consider enhancing the error message to be more user-friendly and informative.

-  print("napari version is too low, please update to version 0.4.19 or higher or downgrade pydantic to version 1")
+  print("Incompatible versions detected: napari must be at least version 0.4.19 and pydantic must be version 2 or lower. Please update napari or downgrade pydantic.")

111-111: Localized import statement for CheckSurveyThread.

Localizing the import statement for CheckSurveyThread within the main function can help avoid circular dependencies and improve clarity. Ensure that this change does not affect the initialization sequence or cause any side effects.


83-83: Correct import statement for version function.

The import statement for the version function from importlib.metadata is correct and necessary for retrieving the installed versions of napari and pydantic.


85-85: Correct import statement for parse function.

The import statement for the parse function from packaging.version, aliased as parse_version, is correct and necessary for parsing and comparing version strings.

pyproject.toml (2)

131-131: Correct version constraint for napari[pyqt6].

The version constraint for napari[pyqt6] has been correctly updated to >=0.5.0, ensuring compatibility with more recent versions.


142-142: Correct version constraint for napari[pyside6_experimental].

The version constraint for napari[pyside6_experimental] has been correctly updated to >=0.5.0, ensuring compatibility with more recent versions.

@Czaki Czaki merged commit 150c68e into develop Jul 19, 2024
68 of 69 checks passed
@Czaki Czaki deleted the fix_constraints_and_add_debug_info branch July 19, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant