-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Enforce napari 0.5.0 for Qt6 bindings #1161
Conversation
WalkthroughThe recent updates introduce enhanced version checks for the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
🧙 Sourcery has finished reviewing your pull request! Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- package/PartSeg/launcher_main.py (3 hunks)
- pyproject.toml (2 hunks)
Additional comments not posted (6)
package/PartSeg/launcher_main.py (4)
82-92
: Ensure correct version checks fornapari
andpydantic
.The version check logic looks correct. It ensures that
napari
is at least version0.4.19
andpydantic
is version2
or lower. However, consider enhancing the error message to be more user-friendly and informative.- print("napari version is too low, please update to version 0.4.19 or higher or downgrade pydantic to version 1") + print("Incompatible versions detected: napari must be at least version 0.4.19 and pydantic must be version 2 or lower. Please update napari or downgrade pydantic.")
111-111
: Localized import statement forCheckSurveyThread
.Localizing the import statement for
CheckSurveyThread
within themain
function can help avoid circular dependencies and improve clarity. Ensure that this change does not affect the initialization sequence or cause any side effects.
83-83
: Correct import statement forversion
function.The import statement for the
version
function fromimportlib.metadata
is correct and necessary for retrieving the installed versions ofnapari
andpydantic
.
85-85
: Correct import statement forparse
function.The import statement for the
parse
function frompackaging.version
, aliased asparse_version
, is correct and necessary for parsing and comparing version strings.pyproject.toml (2)
131-131
: Correct version constraint fornapari[pyqt6]
.The version constraint for
napari[pyqt6]
has been correctly updated to>=0.5.0
, ensuring compatibility with more recent versions.
142-142
: Correct version constraint fornapari[pyside6_experimental]
.The version constraint for
napari[pyside6_experimental]
has been correctly updated to>=0.5.0
, ensuring compatibility with more recent versions.
Summary by CodeRabbit
New Features
napari
andpydantic
.Bug Fixes
napari
, requiring a minimum version of0.5.0
for better stability, for qt6 bindingsChores