Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: require napari>=0.5.0 only for python 3.9+ #1162

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

Czaki
Copy link
Collaborator

@Czaki Czaki commented Jul 19, 2024

Summary by CodeRabbit

  • New Features

    • Introduced conditional dependencies for napari based on Python version, ensuring compatibility for users on Python 3.9 or higher.
  • Bug Fixes

    • Enhanced dependency management to prevent potential compatibility issues in older Python environments.

@Czaki Czaki added this to the 0.15.4 milestone Jul 19, 2024
Copy link
Contributor

coderabbitai bot commented Jul 19, 2024

Walkthrough

The recent changes to the pyproject.toml file enhance dependency management for the pyqt6 and pyside6 packages by introducing conditional requirements for the napari package. Specifically, the installation of napari now depends on the Python version, ensuring compatibility for users running Python 3.9 or higher. This update aims to prevent potential issues in environments with older Python versions while maintaining overall functionality.

Changes

Files Change Summary
pyproject.toml Modified napari dependency for both pyqt6 and pyside6 to require Python 3.9 or higher.

Poem

🐰 In the garden of code where the bunnies play,
We’ve added some checks to brighten the day.
With napari now waiting for Python so fine,
Compatibility blossoms, our project will shine!
Hoppin' through versions, no bugs in our way,
Thank you, dear Python, for leading the way! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. We don't review packaging changes - Let us know if you'd like us to change this.

Copy link

sonarcloud bot commented Jul 19, 2024

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 150c68e and 9a17e27.

Files selected for processing (1)
  • pyproject.toml (2 hunks)
Additional comments not posted (2)
pyproject.toml (2)

131-131: LGTM! Conditional dependency for napari[pyqt6] based on Python version.

The conditional dependency ensures compatibility with Python 3.9 or higher.


142-142: LGTM! Conditional dependency for napari[pyside6_experimental] based on Python version.

The conditional dependency ensures compatibility with Python 3.9 or higher.

@Czaki Czaki merged commit 5d64c20 into develop Jul 19, 2024
66 of 67 checks passed
@Czaki Czaki deleted the build_conditional_deps branch July 19, 2024 12:36
@coderabbitai coderabbitai bot mentioned this pull request Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant