Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow to set zoom factor from interface in Search Label napari plugin #538

Merged
merged 4 commits into from
Feb 18, 2022

Conversation

Czaki
Copy link
Collaborator

@Czaki Czaki commented Feb 18, 2022

Add the possibility to set zoom factor for search labels.

Zrzut ekranu z 2022-02-18 10-49-09

fix #537

@Karol-G this is what you request?

@Czaki Czaki added this to the 0.14.0 milestone Feb 18, 2022
@Karol-G
Copy link

Karol-G commented Feb 18, 2022

Yes, this looks really good. Thank you :)

@deprecated-napari-hub-preview-bot

Preview page for your plugin is ready here:
https://preview.napari-hub.org/4DNucleome/PartSeg/538

@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #538 (4938a04) into develop (79869cf) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #538      +/-   ##
===========================================
+ Coverage    76.87%   76.88%   +0.01%     
===========================================
  Files          144      144              
  Lines        18585    18595      +10     
===========================================
+ Hits         14287    14297      +10     
  Misses        4298     4298              
Impacted Files Coverage Δ
...tSeg/plugins/napari_widgets/search_label_widget.py 92.18% <100.00%> (+0.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79869cf...4938a04. Read the comment docs.

@Czaki Czaki changed the title Allow to set zoom factor from interface in Search Label napari plugin feat: Allow to set zoom factor from interface in Search Label napari plugin Feb 18, 2022
@Czaki
Copy link
Collaborator Author

Czaki commented Feb 18, 2022

New video for description

2022-02-18.11-52-13.mp4

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Feb 18, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 2.11%.

Quality metrics Before After Change
Complexity 3.79 ⭐ 3.79 ⭐ 0.00
Method Length 73.64 🙂 79.55 🙂 5.91 👎
Working memory 9.27 🙂 9.55 🙂 0.28 👎
Quality 65.52% 🙂 63.41% 🙂 -2.11% 👎
Other metrics Before After Change
Lines 146 157 11
Changed files Quality Before Quality After Quality Change
package/PartSeg/plugins/napari_widgets/search_label_widget.py 65.52% 🙂 63.41% 🙂 -2.11% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
package/PartSeg/plugins/napari_widgets/search_label_widget.py SearchLabel._highlight 6 ⭐ 158 😞 14 😞 49.55% 😞 Try splitting into smaller methods. Extract out complex expressions
package/PartSeg/plugins/napari_widgets/search_label_widget.py SearchLabel._shift_if_need 7 ⭐ 222 ⛔ 9 🙂 52.04% 🙂 Try splitting into smaller methods
package/PartSeg/plugins/napari_widgets/search_label_widget.py SearchLabel._zoom 3 ⭐ 135 😞 11 😞 59.69% 🙂 Try splitting into smaller methods. Extract out complex expressions
package/PartSeg/plugins/napari_widgets/search_label_widget.py SearchLabel.__init__ 0 ⭐ 146 😞 9 🙂 65.41% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@deprecated-napari-hub-preview-bot

Preview page for your plugin is ready here:
https://preview.napari-hub.org/4DNucleome/PartSeg/538

@Karol-G
Copy link

Karol-G commented Feb 18, 2022

Very cool! Thanks a lot again :)

@Czaki Czaki merged commit b0f29ad into develop Feb 18, 2022
@Czaki Czaki deleted the feature/zoom_factor branch February 18, 2022 11:21
@Czaki Czaki added the enhancement New feature or request label Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add adjustable zoom for Search Label widget
2 participants