Beanstalk Bugfix #127
Merged
Beanstalk Bugfix #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
willronchetti
commented
Jan 6, 2021
willronchetti
commented
- Parses Beanstalk API correctly and passes region.
netsettler
approved these changes
Jan 6, 2021
dcicutils/beanstalk_utils.py
Outdated
| @@ -393,9 +393,9 @@ def _get_beanstalk_configuration_settings(env): | |||
| } | |||
| """ | |||
| try: | |||
| client = boto3.client('elasticbeanstalk') | |||
| client = boto3.client('elasticbeanstalk', region_name='us-east-1') | |||
There was a problem hiding this comment.
I've noticed this is sometimes not passed.
- Should we have a wrapper that always adds this?
- Should we have a variable that holds the region name? It might actually want to be a configuration param.
A comment noting possible future work would probably be fine here.
Co-authored-by: Kent M Pitman <netsettler@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.