Remove dead code of alwaysLoaded #7175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClementPasteau
approved these changes
Nov 19, 2024
4ian
reviewed
Nov 19, 2024
4ian
reviewed
Nov 19, 2024
4ian
reviewed
Nov 19, 2024
|
I did the fix you mentionned. Can I ask why we are keeping these, I can't see any part of the code from the repo using this property. Even for json. |
|
You're right! Your original changes were correct. You can remove all the alwaysLoaded like you originally did 👍 |
This reverts commit fcb0c73.
4ian
approved these changes
Nov 20, 2024
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: GDevelopApp/GDevelop-documentation#235
Documentation fix:
#7173
Be sure to mention in the next release notes:
Textures are loaded dynamically when needed in a scene, while audio files must be preloaded on some hardware to prevent delays before playback.This PR remove dead code, ensuring users understand it had zero effect on their games! This was old code from GD4. The most important part is to clarify that the optimizations are only for preloading audio files.