Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Developers: Requested Rippers up-for-grabs (meta-issue) #510

Closed
11 tasks
metaprime opened this issue Apr 25, 2017 · 3 comments
Closed
11 tasks

Developers: Requested Rippers up-for-grabs (meta-issue) #510

metaprime opened this issue Apr 25, 2017 · 3 comments
Labels
discussion enhancement help wanted (moved to ripmeapp/ripme)

Comments

@metaprime
Copy link
Collaborator

metaprime commented Apr 25, 2017 •
edited
Loading

Note: assume all links are NSFW

If you would like to develop a ripper which has been requested, please open an issue (to function as a work item) indicating that you've claimed a ripper and you're working on an implementation. Please link back to this issue (and #502 as an FYI) so that GitHub makes a link to the issue (work item) appear in this thread and #502.

I'm locking this conversation to ensure requests and general comments stay on #502. (It looks like link-backs won't appear on a locked issue, so I won't be able to lock this issue.)

To keep this issue focused, I will delete requests and non-dev-related comments (please use #502 for these).

Below is a list of rippers and functionality requested via #502 and #8 (this list is a work in progress -- I'm posting a thumbs-up reaction on any requests I have added to this list). Please assume all links are NSFW.

High priority (existing rippers: broken or missing functionality)

Everything else:

Pending sites + examples (from #8)

Enhancement requests (list from #8):

Acknowledged but defunct requests:
Repository owner locked and limited conversation to collaborators Apr 25, 2017
Repository owner unlocked this conversation Apr 25, 2017
Repository owner locked and limited conversation to collaborators Apr 25, 2017
@metaprime metaprime mentioned this issue Apr 25, 2017
Open
@metaprime metaprime changed the title Developers: Requested Rippers up-for-grabs Developers: Requested Rippers up-for-grabs (meta-issue) Apr 25, 2017
This was referenced Apr 25, 2017
Closed
Closed
Repository owner unlocked this conversation Apr 25, 2017
@Wiiplay123
Copy link
Contributor

Wiiplay123 commented Apr 26, 2017 •
edited
Loading

I've made a working implementation to fix deviantArt ripping and submitted a pull request, but I think it could be done better when someone has the time if they use org.json. Should I still make an issue even if I'm not likely to be able to continue to devote much time to it?

@metaprime
Copy link
Collaborator Author

@Wiiplay123 I think there are plenty of issues already open to track the various DeviantArt problems. If you have a patch, please open a PR. If you don't think it's good enough, it won't work, or whatever, please make that clear in the pull request description. Maybe someone else will be able to pick up the work.

@Wiiplay123
Copy link
Contributor

I opened a PR, turns out the modified ripper is even better than the original ripper, since it accounts for those annoying download redirects that redirect you back to the gallery page.

This was referenced Aug 10, 2017
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion enhancement help wanted (moved to ripmeapp/ripme)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@metaprime @Wiiplay123