Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeviantArt: Downloading a DA artist directory only downloads Featured images, not all images #63

Open
Phenrei opened this issue Jun 8, 2014 · 5 comments

Comments

@Phenrei
Copy link

Phenrei commented Jun 8, 2014

If you point directly to the full image collection of an artist instead of a subgallery, it only downloads the featured section (sometimes empty, usually not every image) instead of the all images category because the sanitizer filters out the "?catpath=/" part.

I coded a half-fix (it breaks the rip stopping on its own for a reason I can't figure out) that is here: Phenrei@8a68c79 (ignore the first change).

Short version of it is a quick regex to see if it's base directory or not, and if so keep the ?catpath=/ in all rip URLs. Feel free to clean up, fix my bug, and take all credit.

@Phenrei
Copy link
Author

Phenrei commented Jun 8, 2014

I realize now it would probably be better to check for the user putting the all images or scraps (?catpath=scraps) parts in the url when sanitizing and then re-add those elements during string creation based on them being present. Just have to move the booleans to the class definition instead of local, but the rest would be similar.

@4pr0n
Copy link
Owner

4pr0n commented Jun 12, 2014

Thanks for pointing this out. I'll take a look at your changes and see what can be pulled/borrowed.

@metaprime metaprime changed the title Downloading a DA artist directory only downloads Featured images, not all images DeviantArt: Downloading a DA artist directory only downloads Featured images, not all images Apr 25, 2017
@rautamiekka
Copy link

#550

@metaprime
Copy link
Collaborator

@rautamiekka Is this the same issue or just similar? Can we leverage the change posted here?

@rautamiekka
Copy link

rautamiekka commented Aug 14, 2017

^ Similar. The change linked in OP potentially fixes the recursive ripping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants