Eroshare can now rip profiles #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BTW, what format/quality options does Eroshare support? |
|
@Hrxn No idea |
|
Well, the web player on the site only lists HD and SD, as it seems. Is that what you are extracting from the source? |
Again I have no idea. I didn't even check the video ripping logic I just added a regex, canRip() and a for loop so it could rip from profile pages. |
|
@cyian-1756 This doesn't seem to work with the rip URLs only option enabled but that wasn't worth blocking the merge. |
|
Released in 1.4.20: https://github.com/4pr0n/ripme/releases/tag/1.4.20 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test link https://eroshare.com/u/onlybestones
Fixes #465