Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check volume value #7

Closed
pelikhan opened this issue Sep 11, 2019 · 1 comment
Closed

check volume value #7

pelikhan opened this issue Sep 11, 2019 · 1 comment

Comments

@pelikhan
Copy link

Add runtime check to ensure that volume is within bounds.

volume = Math.clamp(0, 20, volume | 0)

dfplayermini/main.ts

Line 127 in e108771

innerCall(0x06, 0x00, volume)

xuefengedu added a commit that referenced this issue Sep 14, 2019
@xuefengedu
Fixes #5,#6,#7
f577d6c
@xuefengedu
Copy link
Member

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pelikhan @xuefengedu