This repository has been archived by the owner on Jun 5, 2023. It is now read-only.
feat: localisation time component, #185 #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diondiondion
approved these changes
Mar 3, 2022
| @@ -61,12 +69,12 @@ function getDateString({ | |||
| const mins = parseInt(offset / ONE_MINUTE); | |||
| dateString = minutesAgoReadout(mins); | |||
| } | |||
| // Occcured today... | |||
| // Occured today... | |||
There was a problem hiding this comment.
Suggested change
| // Occured today... | |
| // Occurred today... |
Sorry 😅
MrSwitch
suggested changes
Mar 3, 2022
src/Time/getDateString.js
Outdated
| @@ -16,10 +16,18 @@ function date(d) { | |||
|
|
|||
| function getDateString({ | |||
| dateTime, | |||
| locale, | |||
| locale = 'en-GB', | |||
There was a problem hiding this comment.
When new Intl.DateTimeFormat(locale, ...) is defined with locale === undefined it will imply the browser default language. Which for which ever language a user selects is still preferable IMO. Otherwise if we set a default, we then have to explicitly state the locale everywhere we use it.
Could you use navigator.language instead like...
Suggested change
| locale = 'en-GB', | |
| locale = navigator.language, |
I'm assuming navigator.language is always going to be present and a string with a single locale reference.
MrSwitch
approved these changes
Mar 3, 2022
|
🎉 This PR is included in version 14.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #185
en-GBhourCycleto24and only setshourCycleto12for locales where we want to displayAM/PMScreenshot:
