Skip to content
This repository has been archived by the owner on Jun 5, 2023. It is now read-only.

fix: pass props through InnerBodyScrollLock component #88

Merged
merged 2 commits into from
May 27, 2020

Conversation

humancatfood
Copy link
Contributor

Proposed changes:

After destructuring {as, children and style} out of the props, pass the {...rest} through to the component it renders.

This fixes:

This lets you do things like giving the ScrollLock element an id, aria-tags, etc.

@humancatfood humancatfood requested a review from diondiondion May 27, 2020 15:11
Copy link
Member

@diondiondion diondiondion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Nitpick, but the convention in the rest of our codebase is to use ...otherProps, could you change that & merge?

@humancatfood humancatfood merged commit 7461459 into master May 27, 2020
@humancatfood humancatfood deleted the pass-props-through-inner-body-scroll-lock branch May 27, 2020 15:39
5app-Machine added a commit that referenced this pull request May 27, 2020
## [9.2.2](v9.2.1...v9.2.2) (2020-05-27)

### Bug Fixes

* pass props through InnerBodyScrollLock component ([#88](#88)) ([7461459](7461459))
@5app-Machine
Copy link
Contributor

🎉 This PR is included in version 9.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants