-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement API fencing #56
Conversation
Minimum allowed coverage is Generated by 🐒 cobertura-action against fc8e0bf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic! 🥇
Left a couple of small comments but looks really solid.
The OpenAPI schema is currently looked botched when running this on SAPI (not sure why). I'll do some digging before merging. |
I had missed inheriting from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! 🚀
Todo
USE_TZ
requirementUSE_TZ = False
Using the allow_if_unmodified_since from this patch requires USE_TZ = True. In my opinion that's best practice anyway and reasonable requirement, let me know if you think we should support USE_TZ = False. We should document the requirement and look into ways of making friendly and early error messages.