Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added interface for models, which can be posted to ChurchTools API #93

Merged
merged 4 commits into from
Aug 26, 2022

Conversation

stollr
Copy link
Collaborator

@stollr stollr commented Aug 24, 2022

This gives us more type safety in the update method of the request builder and in the create method, that I am planning to implement soon ;-)

@DumbergerL
Copy link
Contributor

@Naitsirch This PR is a great idea! Only a few suggestions:

  • I moved the Interface to a separate folder similar to the traits
  • i renamed the interface. "PostableModelInterface" seemed for me a bit technical. I know you ment the Post-HTTP-Method but i would keep this in a business/data related language. Are you fine with "UpdateableModel"?

@stollr
Copy link
Collaborator Author

stollr commented Aug 26, 2022

I also thought about something like "updateable" but I had doubts because it is a bit confusing, because the models theirselfes are always updateable by their setters.

But naming things is one of the hardest tasks in Software development :-D

Anyways, I am alright with your changes ;-)

@DumbergerL DumbergerL merged commit bd2eb26 into 5pm-HDH:master Aug 26, 2022
@stollr stollr deleted the postable_model branch September 3, 2022 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants