Fix item view style (#204)

From Qt 6.4.1, some item view style are changed. I don't know this is bug or not. Anyway I make this change close to previous style, because new style is dirty.
5yutan5 · Dec 12, 2022 · ddc345e · ddc345e
1 parent f26d151
commit ddc345e
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 10 deletions.
diff --git a/qdarktheme/_resources/_template_stylesheet.py b/qdarktheme/_resources/_template_stylesheet.py
@@ -792,6 +792,12 @@
 QTreeView::branch:!selected:hover {
     background: {{ list.hoverBackground|color }};
 }
+QTreeView::branch:!selected:hover,
+QTreeView::branch:alternate,
+QTreeView::branch:selected,
+QTreeView::branch:selected:!active {
+    {{ |env(value="background: transparent;", version=">=6.4.1") }}
+}
 QTreeView::branch {
     border-image: {{ tree.inactiveIndentGuidesStroke|color|url(id="vertical_line") }} 0;
 }
@@ -860,15 +866,17 @@
 QTableView {
     gridline-color: {{ tableSectionHeader.background|color }};
     background: {{ background|color(state="table") }};
+    {{ primary|color(state="table.selectionBackground")|env(value="selection-background-color: ${};", version=">=6.4.1") }}
+    {{ table.alternateBackground|color|env(value="alternate-background-color: ${};", version=">=6.4.1") }}
+}
+QTableView:!active {
+    {{ primary|color(state="table.inactiveSelectionBackground")|env(value="selection-background-color: ${};", version="<6.4.1") }}
 }
 QTableView::item:alternate {
-    background: {{ table.alternateBackground|color }};
+    {{ table.alternateBackground|color|env(value="background: ${};", version="<6.4.1") }}
 }
 QTableView::item:selected {
-    background: {{ primary|color(state="table.selectionBackground") }};
-}
-QTableView::item:selected:!active {
-    background: {{ primary|color(state="table.inactiveSelectionBackground") }};
+    {{ primary|color(state="table.selectionBackground")|env(value="background: ${};", version="<6.4.1") }}
 }
 QTableView QTableCornerButton::section {
     margin: 0 1px 1px 0;

diff --git a/style/base.qss b/style/base.qss
@@ -996,6 +996,12 @@ QTreeView::item:!selected:hover,
 QTreeView::branch:!selected:hover {
     background: {{ list.hoverBackground|color }};
 }
+QTreeView::branch:!selected:hover,
+QTreeView::branch:alternate,
+QTreeView::branch:selected,
+QTreeView::branch:selected:!active {
+    {{ |env(value="background: transparent;", version=">=6.4.1") }}
+}
 QTreeView::branch {
     border-image: {{ tree.inactiveIndentGuidesStroke|color|url(id="vertical_line") }} 0;
 }
@@ -1079,15 +1085,17 @@ examples: https://doc.qt.io/qt-5/stylesheet-examples.html#customizing-qtableview
 QTableView {
     gridline-color: {{ tableSectionHeader.background|color }};
     background: {{ background|color(state="table") }};
+    {{ primary|color(state="table.selectionBackground")|env(value="selection-background-color: ${};", version=">=6.4.1") }}
+    {{ table.alternateBackground|color|env(value="alternate-background-color: ${};", version=">=6.4.1") }}
+}
+QTableView:!active {
+    {{ primary|color(state="table.inactiveSelectionBackground")|env(value="selection-background-color: ${};", version="<6.4.1") }}
 }
 QTableView::item:alternate {
-    background: {{ table.alternateBackground|color }};
+    {{ table.alternateBackground|color|env(value="background: ${};", version="<6.4.1") }}
 }
 QTableView::item:selected {
-    background: {{ primary|color(state="table.selectionBackground") }};
-}
-QTableView::item:selected:!active {
-    background: {{ primary|color(state="table.inactiveSelectionBackground") }};
+    {{ primary|color(state="table.selectionBackground")|env(value="background: ${};", version="<6.4.1") }}
 }
 
 QTableView QTableCornerButton::section {