Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix frame border issue #57

Merged
merged 2 commits into from
Jan 5, 2022
Merged

Fix frame border issue #57

merged 2 commits into from
Jan 5, 2022

Conversation

5yutan5
Copy link
Owner

@5yutan5 5yutan5 commented Jan 5, 2022

This PR fix the frame border issue as discussed in #54.
This fix will only work if QWidget is entered into QScrollArea.setWidget().
This is because it forces the background of a child widget of QScrollArea to be transparent, which may cause the color of widgets whose background color is different from the base color, such as QPushButtoon and QTableView, to disappear.

  • Fixed a bug where widgets in scroll area would hide a part of scroll area border when padding of scroll area is 0.

@codecov
Copy link

codecov bot commented Jan 5, 2022

Codecov Report

Merging #57 (c538cb2) into main (25e60f9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #57   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           19        19           
  Lines          585       585           
=========================================
  Hits           585       585           
Impacted Files Coverage Δ
qdarktheme/themes/dark/rc_icons.py 100.00% <ø> (ø)
qdarktheme/themes/dark/stylesheet.py 100.00% <ø> (ø)
qdarktheme/themes/light/rc_icons.py 100.00% <ø> (ø)
qdarktheme/themes/light/stylesheet.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25e60f9...c538cb2. Read the comment docs.

@5yutan5 5yutan5 merged commit 6054b58 into main Jan 5, 2022
@5yutan5 5yutan5 deleted the Fix-frame-border-issue branch January 5, 2022 20:15
This was referenced Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant