Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement PartialEq for Role #63

Merged
merged 1 commit into from
Apr 2, 2023
Merged

Implement PartialEq for Role #63

merged 1 commit into from
Apr 2, 2023

Conversation

schneiderfelipe
Copy link
Contributor

No description provided.

@64bit
Copy link
Owner

64bit commented Mar 31, 2023

Nice addition, thank you for PR @schneiderfelipe .

I'm thinking to derive PartialEq for all types to be consistent.
I'll add it before releasing this, in the meantime you're welcome to add them too if your time allows.

@64bit 64bit merged commit c27e964 into 64bit:main Apr 2, 2023
@64bit
Copy link
Owner

64bit commented Apr 2, 2023

This is released in v0.10.2

@schneiderfelipe schneiderfelipe deleted the partialeq-role branch April 2, 2023 13:25
@schneiderfelipe
Copy link
Contributor Author

Hey, I see you've implemented PartialEq for all types as you said, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@64bit 64bit 64bit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schneiderfelipe @64bit