ESM/CJS interop #58
Merged
ESM/CJS interop #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using a default export causes the module build file to be used by typescript when it transpiles to cjs, which then doesn't work for mixing esm and cjs. Simply removing the default line resolves the issue. Fixes #57
working with jsep plugin types then forces those imports into the exported typings, even if a user is not using those plugins. Instead, work with the generic jsep.Expression to simplify the exported types.
|
🎉 This PR is included in version 1.4.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
exports.defaultentry from package.json to resolve the issue with typescript transpiled to cjs using the ESM (default) module instead of the CJS build as neededClean up types, enable commented out tests with newer jsep packages
Fixes #57