This repository has been archived by the owner on Mar 7, 2022. It is now read-only.
Add missing space between text and URL on WhatsApp sharing #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @alejandroiglesias thanks a lot, can you just please remove the Also why not just a space instead of new line? :P |
Done! 👍
I think it looks better that way. |
|
Would you like to merge it so that we can point our app dependency back to this repo? |
45kb
added a commit
that referenced
this pull request
Jun 23, 2017
|
@alejandroiglesias done! thank you. |
|
@45kb great! 😄 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a space (actually a newline) between the text and the URL for WhatsApp sharing. Before, the text and the URL were together:
The URL was interpreted as normal text by WhatsApp (
TEXThttp://myurl.com). Now they have a newline in between:And also WhatsApp shows the preview for the URL now since the URL is correct.