Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close #189 and #191 #193

Merged
merged 6 commits into from
Jan 21, 2017
Merged

Close #189 and #191 #193

merged 6 commits into from
Jan 21, 2017

Conversation

simonepri
Copy link
Contributor

@simonepri simonepri commented Jan 21, 2017

This PR fix these:
#191
#189

@45kb
Copy link
Member

45kb commented Jan 21, 2017

@simonepri Hey! thanks a lot for this. Have you tested all and it's all working correct?

Just curious but why does removing this line unregisterOnTooltipControllerChange(); ? :)

@simonepri
Copy link
Contributor Author

Sorry @45kb it was an error. I've just re-added it
Yes everything seems ok now.

@45kb
Copy link
Member

45kb commented Jan 21, 2017

cool @simonepri thanks a lot! seriously appreciated 💯

@45kb 45kb merged commit f47e718 into 720kb:master Jan 21, 2017
@45kb
Copy link
Member

45kb commented Jan 21, 2017

you can now update the lib to 1.1.9 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants