Rollup plugin Circular Dependency issue

[dananderson]

command-line-args caused this error with rollup:

(!) Circular dependency: node_modules/command-line-args/lib/option.js -> node_modules/command-line-args/lib/option-flag.js -> node_modules/command-line-args/lib/option.js

A fix would be to move Option/OptionFlag.create to a new OptionFactory class file and update create callers to use the factory.

[75lb]

Hi, could you post a reproduction case please - some code I can debug and fix. Thanks.

[dananderson]

Thanks for looking into this.

https://github.com/dananderson/command-line-args-cicular-dependency

npm
npm run rollup
node one.js

My rollup target environment is node with es6 classes. rollup produces one.js with a circular dependency warning. one.js is created, but running one.js results in a runtime error due to the circular dependency.

[75lb]

thanks for the reproduction case.

The option-flag module is lazy-loaded at run time therefore does not cause a compile-time circular reference. This is a rollup issue caused by a bug in rollup-plugin-commonjs.

Do you have a quick fix for this? If so, please drop me a PR. The long-term fix is to upgrade the command-line-args project to offer an ESM entry-point (as well as CJS). I'll do that when I next get chance.

[dananderson]

Thanks for digging into the rollup stuff.

The root cause seems to be how rollup translates inline requires. I suspect it is not worth fixing on the rollup side because user land expects the existing behavior.. and es modules are coming.

The long term fix would be an es module. For the short term, it would be nice to get command-line-args working with rollup. I'll propose a PR next week and we can discuss if it fits into your project.

[75lb]

Fixed and released in v5.1.0.