Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for views #14

Merged
merged 2 commits into from
Feb 4, 2019
Merged

Add support for views #14

merged 2 commits into from
Feb 4, 2019

Conversation

Morozzzko
Copy link
Contributor

@Morozzzko Morozzzko commented Jan 27, 2019 •
edited
Loading

Rails 5.1 made a clear distinction between views and tables, so the dumper stopped working.

Fixed it.

Some pry-level debugging:

[18] pry(main)> connection.table_exists?(table_name) || connection.view_exists?(table_name)
true
[19] pry(main)> connection.table_exists?(table_name)
false

Fixes #12

7even
7even requested changes Feb 3, 2019
View reviewed changes
lib/active_record/annotate/dumper.rb Outdated Show resolved Hide resolved
@7even @Morozzzko
Update lib/active_record/annotate/dumper.rb
a50c0d2 
Co-Authored-By: Morozzzko <igor@morozov.is>
@7even 7even merged commit d4ab3e9 into 7even:master Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7even 7even 7even approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Morozzzko @7even