Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(prefetch): import QueryClient type #105

Merged
merged 1 commit into from
May 3, 2024
Merged

Conversation

seriouslag
Copy link
Collaborator

@seriouslag seriouslag commented May 3, 2024

In some instances, the QueryClient import was not auto-detected by ts-morph.

The fix is to - Explicitly add the type import.

ts-morph doesn't seem to have an issue removing the import if it is not being used in a file.

In some instances the QueryClient import was not be auto-detected by ts-morph.

Explicitly add the type import.
@seriouslag seriouslag requested a review from 7nohe May 3, 2024 16:37
@seriouslag seriouslag added the bug Something isn't working label May 3, 2024
Copy link

github-actions bot commented May 3, 2024

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 99.07% (🎯 95%) 1826 / 1843
🟢 Statements 99.07% (🎯 95%) 1826 / 1843
🟢 Functions 100% (🎯 95%) 40 / 40
🟢 Branches 94.51% (🎯 85%) 155 / 164
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/createImports.mts 96.29% 71.42% 100% 96.29% 22-25, 29
Generated in workflow #253

@7nohe 7nohe merged commit 5035fb5 into main May 3, 2024
4 checks passed
@7nohe 7nohe deleted the patch/add-query-client-import branch May 3, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants