Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(preview): update browser preview ui #5

Merged
merged 3 commits into from
May 20, 2020
Merged

Conversation

Tiierr
Copy link
Contributor

@Tiierr Tiierr commented May 19, 2020

No description provided.

@7sDream
Copy link
Owner

7sDream commented May 19, 2020

Please rebase your branch to updated master and push it again.

I recently add CI for pull request and from now PRs need checks passed before merge.

@7sDream 7sDream self-requested a review May 19, 2020 20:33
Copy link
Owner

@7sDream 7sDream left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM, just needs a rebase to pass CI checks

Copy link
Owner

@7sDream 7sDream left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the HTML structure, and add your changes to CHANGELOG.md's Unreleased section.

src/preview/browser/statics/template.html Show resolved Hide resolved
@7sDream 7sDream changed the title feat(render): update browser preview ui style(preview): update browser preview ui May 20, 2020
Copy link
Owner

@7sDream 7sDream left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@7sDream 7sDream merged commit 7435bd2 into 7sDream:master May 20, 2020
7sDream added a commit that referenced this pull request May 20, 2020
- Browser preview page gets a new wonderful UI (Thanks [@Tiierr](https://github.com/Tiierr), PR #5)
@7sDream 7sDream mentioned this pull request May 20, 2020
7sDream added a commit that referenced this pull request May 20, 2020
- Browser preview page gets a new wonderful UI (Thanks [@Tiierr](https://github.com/Tiierr), PR #5)
7sDream added a commit that referenced this pull request May 20, 2020
- Browser preview page gets a new wonderful UI (Thanks [@Tiierr](https://github.com/Tiierr), PR #5)
@7sDream 7sDream mentioned this pull request May 20, 2020
7sDream added a commit that referenced this pull request May 20, 2020
- Browser preview page gets a new wonderful UI (Thanks [@Tiierr](https://github.com/Tiierr), PR #5)
7sDream added a commit that referenced this pull request May 20, 2020
- Browser preview page gets a new wonderful UI (Thanks [@Tiierr](https://github.com/Tiierr), PR #5)
7sDream added a commit that referenced this pull request May 20, 2020
- Browser preview page gets a new wonderful UI (Thanks [@Tiierr](https://github.com/Tiierr), PR #5)
7sDream added a commit that referenced this pull request May 20, 2020
- Browser preview page gets a new wonderful UI (Thanks [@Tiierr](https://github.com/Tiierr), PR #5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants