Fish fixes #1186
Merged
Fish fixes #1186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And since we no longer need to preserve existing contents, overwrite instead of append.
Otherwise they wind up in $XDG_CONFIG_HOME/fish/fish_variables and pollute the environment on the host.
|
Thanks a lot @yump yes that was a debug string leftover 😅 thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing a git-diff of my
~/.config/fish/(on the host) , I found some mysterious additions to fish_variables (SHELL,UID,MARONNE). Thanks to the unique string "MARONNE", I was able to track down the culprit: an/etc/fish/conf.d/config.fishwritten (seven times) by distrobox-init."MARONNE" seems most likely to be the result of a find/replace with clipboard contents? The command that sets it is otherwise the same as the previous line.
And then I searched for "fish" in the bug tracker to see if this had been reported already, and found #1115, so I fixed that too.