zsh completions: fixed issue with some arguments having invalid syntax

[fredricocalamari]

Fixed issue where the completions were showing invalid syntax ex. '--additional-flags' and a few others were being incorrectly completed as '--additional-flags='

[89luca89]

Thanks a lot @fredricocalamari !

Seeing that you're a zsh user, can I ask you if you can help with the installation path of zsh autocompletion? Regarding #1213

[onurmercury]

I'm sure now it is $prefix/share/zsh/site-functions

for e.g.
https://build.opensuse.org/package/view_file/shells:zsh-users:zsh-completions/zsh-completions/zsh-completions.spec?expand=1

https://github.com/NixOS/nixpkgs/blob/711b0df6923c889ebb7d6deced2c76a2f41b445f/pkgs/shells/zsh/zsh-completions/default.nix#L16

[fredricocalamari]

Thanks a lot @fredricocalamari !

Seeing that you're a zsh user, can I ask you if you can help with the installation path of zsh autocompletion? Regarding #1213

Zsh completions are put in

/usr/share/zsh/site-functions

*I recommended placing them in a different function folder earlier, and that works too, but @onurmercury is also correct and site-functions is easier.

or a custom directory like

~/.local/zsh/completions

distrobox should go in the /usr/share/zsh/site-functions folder or If you want, you can store zsh completion files in a custom directory. This is what I do:
I create directories

mkdir -p ~/.local/zsh/completions

Then I chmod 644 the completion files and then I symlink or copy them into that directory. Do not organize them into subdirectories. Just put them all in one folder. After that, open ~/.zshrc and add this towards the top. It doesn't have to be at the very top, just above most everything else and among a common section with setting/exporting of environmental variables:

fpath=(~/.local/zsh/completions/ $fpath)
autoload -Uz compinit && compinit
for func in $^fpath/*(N-.x:t); do
    autoload $func
done

I don't think the last 3 lines are strictly necessary. I'ts probably just ocd. Anyways, restart zsh and type distrobox<space><tab> and the zsh compinit system should show a complete list of arguments with descriptions below. The zsh completion system is incredibly advanced (and MUCH more complicated to code for) than Bash and you can continue combining and completing subcommands with dashes to see what other arguments apply to the compound command.

[fredricocalamari]

I'm sure now it is $prefix/share/zsh/site-functions

for e.g. https://build.opensuse.org/package/view_file/shells:zsh-users:zsh-completions/zsh-completions/zsh-completions.spec?expand=1

https://github.com/NixOS/nixpkgs/blob/711b0df6923c889ebb7d6deced2c76a2f41b445f/pkgs/shells/zsh/zsh-completions/default.nix#L16

that works too, it's up to your preference

[89luca89]

Thanks everyone for the info!

And thanks @fredricocalamari for the fixes!