export: consider only absolute candidate icon paths that exist #1318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamiKettunen
force-pushed
the
fix-pwd-icon-confusion
branch
from
2eb3415 to
c9769cf
Compare
Previously (for nearly two years?) attempting e.g. "distrobox-export -a htop" with a file/dir named "htop" in $PWD it would mistakenly get detected as the icon for the program, copied over to ~/.local/share/icons/ and attempted to be used by the .desktop file.
JamiKettunen
force-pushed
the
fix-pwd-icon-confusion
branch
from
c9769cf to
ef1f98c
Compare
JamiKettunen
changed the title
|
@89luca89 Would you mind taking a look at some of the open pull requests when you have time? Thanks :) |
|
Hi @JamiKettunen sorry was pretty busy :) LGTM thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously (for nearly two years since 4522f29?) attempting e.g.
distrobox-export -a htopwith a file/dir namedhtopin$PWDit would mistakenly get detected as the icon for the program, copied over to~/.local/share/icons/and attempted to be used by the.desktopfile.Not sure if this is following the spec exactly but it does fix this very odd issue I only noticed because I happened to have a local git tree checkout of a program in my
$HOMEand while there tried to export a launcher for it to my host and dug deeper when the icon was showing up as entirely blank in GNOME.