all: properly handle env vars and configs in all commands #1328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luca Di Maio <luca.dimaio1@gmail.com>
|
Thanks a lot @xarvex! Not in all places this is needed (see export,host-exec,init) Reverted that for those, and keeping for all the others :) thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I was adding an option to quiet the output (which I will make a PR for after this), I noticed that not all commands handled environment variable options and/or configs, even though they use options that would be affected such as
non_interactiveandverbose.There are as well certain tweaks for consistency and readability, please see commits for specifics on that. I have highlighted the important details here:
Environment Variables
DBX_NON_INTERACTIVEwas added in 7203563, but has not been added to new files since then.DBX_VERBOSEwas added in 78b3319, but was not handled in all files that use verbose as an option.Configs
Were not being processed in all commands, despite being relevant to them.
Affected
Not counting minor tweaks.
distrobox-assembledistrobox-ephemeraldistrobox-exportdistrobox-host-execdistrobox-init