host-exec: Fix CONTAINER_ID: unbound variable error #888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the script sets the nounset shell option, but it doesn't
define the CONTAINER_ID variable and nor it should (something else does
it). In such cases, we should resort to shell parameter expansion in
order to use a default value (an empty string, in this case) if the
parameter - read CONTAINER_ID variable - is unset or null.
So, we should use "${CONTAINER_ID:-}" instead, to avoid this error.
Fixes 89luca89#882
Signed-off-by: Luciano Santos <luciano.santos@email.com>
Use "download_command" instead, and initialize it in the top of the script (download_command=""). This should avoid "unbound variable" errors in unfortunate cases where curl nor wget are found, and the variable would remain unset. Signed-off-by: Luciano Santos <luciano.santos@email.com>
|
Thanks a lot for the fix @luc14n0 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the script sets the
nounsetshell option, but it doesn't define theCONTAINER_IDvariable and nor it should (something else does it). In such cases, we should resort to shell parameter expansion in order to use a default value (an empty string, in this case) if the parameter - readCONTAINER_IDvariable - is unset or null.So, we should use
${CONTAINER_ID:-}instead, to avoid this error.Fixes #882