Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export: Add call to update-desktop-database tool #889

Conversation

luc14n0
Copy link
Contributor

@luc14n0 luc14n0 commented Aug 3, 2023

That's important to ensure exported applications will show up in whatever the user/DE is using desktop files for (taskbars, desktop menus, etc) right after exportation.

Desktop Environments should already install update-desktop-database by default - that's how they handle packages installing .desktop files. I'd believe that most Window Managers should also have it.

That's important to ensure exported applications will show up in
whatever the user/DE is using desktop files for (taskbars, desktop
menus, etc) right after exportation.

Signed-off-by: Luciano Santos <luciano.santos@email.com>
@89luca89
Copy link
Owner

89luca89 commented Aug 3, 2023

Thanks @luc14n0

If we add a base dependency we need to add it to the init also

Instead of this, I was thinking we probably want to update the host's desktop-database
So instead of this maybe we can do this:

/usr/bin/distrobox-host-exec --yes update-desktop-database -q 2> /dev/null || :

So this will either force-update the desktop-db on the host, or fail silently if the host doesn't have the tool

@luc14n0
Copy link
Contributor Author

luc14n0 commented Aug 3, 2023

Instead of this, I was thinking we probably want to update the host's desktop-database

Duh, my bad.

So instead of this maybe we can do this:

/usr/bin/distrobox-host-exec --yes update-desktop-database -q 2> /dev/null || :

So this will either force-update the desktop-db on the host, or fail silently if the host doesn't have the tool

Sounds good to me.

Signed-off-by: Luca Di Maio <luca.dimaio1@gmail.com>
@89luca89
Copy link
Owner

89luca89 commented Aug 3, 2023

Added the fix quickly and merging :)

Thanks a lot!

@89luca89 89luca89 merged commit 3501c56 into 89luca89:main Aug 3, 2023
@luc14n0
Copy link
Contributor Author

luc14n0 commented Aug 3, 2023

Sure thing. Thanks for the amendment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants