Upgrade PHPUnit to 7.5.x #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
RageZBla
commented
Oct 12, 2019
RageZBla
commented
| Q | A |
|---|---|
| Bug fix | no |
| New feature | yes |
| BC breaks | no |
| Deprecations | no |
| Tests pass | yes |
| Fixed tickets | #275 |
| License | MIT |
RageZBla
force-pushed
the
phpunit-upgrade-to-version-7
branch
from
e6becb2 to
3860ab3
Compare
RageZBla
force-pushed
the
phpunit-upgrade-to-version-7
branch
from
3860ab3 to
8ddfe11
Compare
gregurco
reviewed
Oct 12, 2019
gregurco
requested changes
Oct 16, 2019
|
And also in tests you can find usage of More info here: https://github.com/sebastianbergmann/phpunit/blob/7.5/src/Framework/MockObject/MockObject.php#L21 |
|
@gregurco thanks for the review, I have addressed your feedback 🙇♂️ |
gregurco
approved these changes
Oct 17, 2019
|
@RageZBla thank you and congratulations with first PR 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.