Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add collapsible request and response section on profiler. #277

Merged
merged 3 commits into from
Oct 31, 2019
Merged

Add collapsible request and response section on profiler. #277

merged 3 commits into from
Oct 31, 2019

Conversation

RageZBla
Copy link
Contributor

Closes #222

Q A
Bug fix no
New feature yes
BC breaks no
Deprecations no
Tests pass yes
Fixed tickets #222
License MIT

@RageZBla
Copy link
Contributor Author

I had to do it without testing in a browser. If someone can point me out to a guide how to test the front end part it would be great 👍

@RageZBla
Copy link
Contributor Author

@gregurco @florianpreusner I took the time to test it out and the javascript is working 💯

image

Let me know if you have any feedback.

@gregurco gregurco self-requested a review October 18, 2019 08:39
@gregurco gregurco added this to the v8 milestone Oct 18, 2019
@RageZBla
Copy link
Contributor Author

By the way to anyone participating in this project, I have published a demo application so you can test out your changes in a browser.

I hope it would be useful to anyone 🤔

gregurco
gregurco approved these changes Oct 30, 2019
View reviewed changes
Copy link
Member

@gregurco gregurco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

florianpreusner
florianpreusner approved these changes Oct 31, 2019
View reviewed changes
Copy link
Member

@florianpreusner florianpreusner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 lgtm!

@gregurco gregurco merged commit 3ebe480 into 8p:master Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregurco gregurco gregurco approved these changes

@florianpreusner florianpreusner florianpreusner approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v8
Development

Successfully merging this pull request may close these issues.

[Profiler] Collapsible Request and Response section
3 participants
@RageZBla @florianpreusner @gregurco